Styling improvements #10483
Merged
Styling improvements #10483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcomack
suggested changes
Aug 1, 2018
| /** | ||
| * Sidebar Collapsible component with default padding and separator | ||
| * | ||
| * @param {object} props The properties for the component. |
| * | ||
| * @returns {ReactElement} The Collapsible component. | ||
| */ | ||
| const SidebarCollapsible = ( props ) => { |
There was a problem hiding this comment.
The name SidebarCollapsible seems odd as we also use it outside of the Sidebar. Additionally, the name is never called outside of this file, so I'm unsure of it's added value.
| * @returns {ReactElement} The Collapsible component. | ||
| */ | ||
| const SidebarCollapsible = ( props ) => { | ||
| return <Collapsible hasPadding={true} hasSeparator={true} {...props} />; |
There was a problem hiding this comment.
I believe the code-style dictates the usage of spaces after { and before }.
jcomack
approved these changes
Aug 1, 2018
|
CR 2 done 👍 |
|
Acceptance done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Snippet Previewis the only opened collapsible by default.Test instructions
This PR can be tested by following these steps:
Quality assurance
I have added unittests to verify the code works as intendedFixes Yoast/yoast-components#671
Requires Yoast/yoast-components#682