Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply padding and separator for Collapsibles #10482

Closed
wants to merge 4,652 commits into from
Closed

Apply padding and separator for Collapsibles #10482

wants to merge 4,652 commits into from

Conversation

moorscode
Copy link
Contributor

@moorscode moorscode commented Aug 1, 2018 •
edited
Loading

Summary

This PR can be summarized in the following changelog entry:

  • N/A

Relevant technical choices:

  • Made sure the Snippet Preview is the only opened collapsible by default.

Test instructions

This PR can be tested by following these steps:

  • View the metabox and sidebar in a Gutenberg edit page.
  • View the metabox in a Classic Editor edit page.
  • View the metabox in a Category edit page.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

boblinthorst and others added 30 commits June 22, 2018 13:54
@boblinthorst
second half
776bb07
Merge pull request #1809 from Yoast/update_yoastComponents_440
0562768 
Bump yoast-components to 4.4.0
Merged Free
8cd014d
Bumped version in Premium directory
e86fa0a
Version bump for RC5
46e26c0
Updated language files
63ab0de
Merge branch 'release/7.7' of https://github.com/Yoast/wordpress-seo …
11d2944 
…into release/7.7
Updated changelog
dc471aa
@IreneStr
Add changelog item
f14d996
@IreneStr
Clarify changelog item
f5b0c93
@IreneStr
Improve wording
be754d8
@moorscode
Merge pull request #1810 from Yoast/stories/add-7.7-cahngelog-item
3e3da05 
Add changelog item
Merge free into premium
b28908a
Bump version
f4ec63b
Build assets
f4301bf
Build language files
e5f5682
Update changelog
25e4340
Build the assets
3712191
@moorscode
Merge branch 'master' into trunk
8eddd23
@moorscode
Rebuild assets
bb726ca
Listen to a term being deleted in JS and show notification.
7fadaf2
Ensure the term watcher sets notifications correctly by supporting th…
77ce780 
…e delete-tag AJAX action.
Use if clauses instead of fallthrough-switch.
cb0765a
@jrfnl
CS: clean up after latest merges
20e7c7a 
Mostly multi-line array layout fixes and some minor documentation fixes for layout, grammar and missing tags.
@jcomack
Merge pull request #1814 from Yoast/1800-show-term-deleted-notification
13d9f63 
Show a notification when a term has been deleted
@moorscode
Merge remote-tracking branch 'origin-free/master' into hotfix/7.7.1-2
97beb82 
# Conflicts:
#	js/dist/commons-771.min.js
#	js/dist/configuration-wizard-770.min.js
#	js/dist/search-appearance-770.min.js
#	js/dist/search-appearance-771.js
#	js/dist/wp-seo-help-center-770.min.js
#	js/dist/wp-seo-modal-770.min.js
#	js/dist/wp-seo-post-scraper-770.min.js
#	js/dist/wp-seo-replacevar-plugin-770.min.js
#	js/dist/wp-seo-term-scraper-770.min.js
#	js/dist/wp-seo-wp-globals-backport-770.min.js
#	wp-seo.php
@moorscode
Have same yoastseo version as the root dir
5b67084
@moorscode
Update yarn.lock file after installing latest version
84b49f9
@moorscode
Added changelog 7.7.1
b2439b0
@moorscode
Rebuild assets
22f7717
omarreiss and others added 25 commits July 26, 2018 17:55
@omarreiss
Merge pull request #1871 from Yoast/gutenberg-linking-suggestions
5647720 
Link suggestions in sidebar
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
73ceeaa
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
c548722
@omarreiss
Fix docs for linking suggestions JS.
539d93b
@omarreiss
Move prominent words to registerPlugin
b780663
@omarreiss
Remove all yoast-premium components leftovers #boyscout
e231bad
@omarreiss
Fix a bunch of codestyle warnings.
1d0642c
@omarreiss
codestyle
a0afc2c
@abotteram
Updated JSDoc
e92c20f
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
a8108ec
@abotteram
Refactored for the sake of readability and addressed eslint issues
763aa8c
@Dieterrr
Merge pull request #1872 from Yoast/gutenberg-prominent-words
24fe730 
Gutenberg prominent words
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
1100e89
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
830c8e6
@atimmer
Merge branch 'trunk' into stories/remove-premium-dependencies
2f0b1e5
@atimmer
Upgrade webpack to 3
7d300ed
@atimmer
Merge pull request #1834 from Yoast/stories/remove-premium-dependencies
1b1e27b 
Remove premium dependencies
@atimmer
Fix textdomain
b439f78
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
5b5d81c
@atimmer
Import Gutenberg from the correct @WordPress imports
dd01c18
Merge pull request #1880 from Yoast/stories/fix-gutenberg-imports
eac5b11 
Import Gutenberg from the correct @WordPress imports
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
315e2db
@atimmer
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into trunk
6144d87
@atimmer
Register premium metabox in non-Gutenberg UI
7c3ec4b
@moorscode
Apply padding and separator for Collapsibles
3782278
@moorscode moorscode mentioned this pull request Aug 1, 2018
Merged
@moorscode moorscode closed this Aug 1, 2018
@moorscode moorscode deleted the components-671-styling-tweaks branch August 1, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.