Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used the yoast plugin icon as pinned plugin icon for gutenberg #10430

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

boblinthorst
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • Added the Yoast icon as pinned plugin icon in Gutenberg.

Relevant technical choices:

  • Kept the styled component in edit.js because it's only a resize, which isn't used anywhere else.
  • Set the size of the icon at 20x20px to match the other icons in the bar.

Test instructions

This PR can be tested by following these steps:

  • Checkout this branch.
  • Make sure the following flag is set : define( 'YOAST_FEATURE_GUTENBERG_SIDEBAR', true );
  • Open a post-edit page.
  • Make sure the yoast-sidebar is pinned ( open the yoast sidebar -> click on the star at the top ).
  • Check if the icon added in the header toolbar by pinning yoast-seo is the yoast icon ( you can check the issue how it used to look for comparision ).

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #10295

@Dieterrr
Copy link
Contributor

CR Done 👍
Acceptance done 👍

@Dieterrr Dieterrr merged commit b9eb6fa into trunk Jul 24, 2018
@Dieterrr Dieterrr deleted the 10295-use-correct-icon-for-gutenberg-sidebar-pin branch July 24, 2018 12:34
@boblinthorst boblinthorst added this to the 8.0 milestone Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants