Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activeKeyword in store to activeSections #9305

Closed
IreneStr opened this issue Mar 21, 2018 · 0 comments
Closed

Change activeKeyword in store to activeSections #9305

IreneStr opened this issue Mar 21, 2018 · 0 comments

Comments

@IreneStr
Copy link
Contributor

IreneStr commented Mar 21, 2018

Currently, we're storing the activeKeyword in the redux state. However, when we're moving the content analysis to the sidebar, we'll have sections, where multiple sections can be active at the same time:

This means there will be no single active keyword anymore. Therefore, we should change the state to contain activeSections, which should be an array (instead of activeKeyword, which is a string).

Current state:

{
	activeKeyword: "string",
	analysis:
		{ 
			readability: [],
			seo: { keyword1: [] } ,
		},
	marksButtonStatus: "string",
}

Future state:

{
	activeSections: [],
	analysis:
		{ 
			readability: [], 
			seo: { keyword1: [] } 
		},
	marksButtonStatus: "string",
}

Please branch from feature/content-analysis-in-sidebar

NB: Connecting to the UI is not part of the scope of the issue. This issue is purely about the actions and reducer.

@maartenleenders maartenleenders self-assigned this Mar 27, 2018
@maartenleenders maartenleenders removed their assignment Mar 28, 2018
@igorschoester igorschoester self-assigned this Mar 29, 2018
@maartenleenders maartenleenders removed their assignment Mar 29, 2018
@abotteram abotteram self-assigned this Mar 29, 2018
@abotteram abotteram removed their assignment Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants