Fix SelectControl deprecation warning

Gutenberg added a deprecation warning for SelectControl via WordPress/gutenberg#38730 This opts in to that behavior and adds the margin top to the ExternalLink below (therefor needing block layout to get the margin to take effect)
Yoast · Sep 12, 2024 · 6565d5e · 6565d5e
1 parent 1584e5a
commit 6565d5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/js/src/components/PrimaryTaxonomyPicker.js b/packages/js/src/components/PrimaryTaxonomyPicker.js
@@ -244,7 +244,7 @@ class PrimaryTaxonomyPicker extends Component {
 					id={ fieldId }
 					terms={ this.state.selectedTerms }
 				/>
-				<ExternalLink href={ learnMoreLink }>
+				<ExternalLink className="yst-inline-block yst-mt-2" href={ learnMoreLink }>
 					{ __( "Learn more", "wordpress-seo" ) }
 					<span className="screen-reader-text">
 						{ __( "Learn more about the primary category.", "wordpress-seo" ) }

diff --git a/packages/js/src/components/TaxonomyPicker.js b/packages/js/src/components/TaxonomyPicker.js
@@ -21,6 +21,7 @@ const TaxonomyPicker = ( { id, value, terms, label, onChange } ) => {
 
 	return (
 		<SelectControl
+			__nextHasNoMarginBottom={ true }
 			__next40pxDefaultSize={ true }
 			id={ id }
 			label={ label }