PHPUnit 11.3.1 | AssertIsList: sync error message with upstream #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 11.3.1 improved the type information in select assertion failure messages. For the polyfills, this only affects the `AssertIsList` polyfill. Now the choice was between the following: * Just update the test(s) to have a different message expectation for PHPUnit 11.3.1+. * Update the polyfills to mirror the improvement made in PHPUnit upstream. I've chosen to implement the latter as it makes the message significantly more informative. This means that on PHPUnit 6.x to 9.x and 11.3.1+, the new, improved message is shown. While on PHPUnit 10.0 - 11.3.0, the "old" message is shown as, in that case, the PHPUnit native `assertIsList()` method is used without the message improvements. Includes: * Renaming the `assertIsListFailureDescription()` method parameter from `$other` to `$value` to be more descriptive. * Updating the tests, including adding an extra test with an anonymous class as that has separate handling for the error message in the polyfill. Refs: * sebastianbergmann/phpunit@5e8b79e * sebastianbergmann/phpunit@42cfc7d
hellofromtonya
deleted the
feature/3.x/assertislist-sync-error-message-with-upstream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 11.3.1 improved the type information in select assertion failure messages.
For the polyfills, this only affects the
AssertIsListpolyfill.Now the choice was between the following:
I've chosen to implement the latter as it makes the message significantly more informative.
This means that on PHPUnit 6.x to 9.x and 11.3.1+, the new, improved message is shown. While on PHPUnit 10.0 - 11.3.0, the "old" message is shown as, in that case, the PHPUnit native
assertIsList()method is used without the message improvements.Includes:
assertIsListFailureDescription()method parameter from$otherto$valueto be more descriptive.Refs: