Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Editor: array_contains_ext()'s "matchall" is optional in documentation, but GM expects it #4973

Closed
backYard321 opened this issue Mar 11, 2024 · 7 comments
Closed

Code Editor: array_contains_ext()'s "matchall" is optional in documentation, but GM expects it #4973

backYard321 opened this issue Mar 11, 2024 · 7 comments
Assignees
@DiasFranciscoA
Labels
ide-bug Bugs with the GameMaker IDE
Milestone
2024.4

Comments

@backYard321
Copy link

backYard321 commented Mar 11, 2024 •
edited
Loading

Description

The page for array_contains_ext() lists the "matchall" argument as optional, but GM will show a warning if it's not included. The game will still work even without it though!

image
image

The documentation also doesn't specify the default value of "matchall" if it's not included:
image

Manual Link

https://manual.gamemaker.io/monthly/en/GameMaker_Language/GML_Reference/Variable_Functions/array_contains_ext.htm
@backYard321 backYard321 added the docs-bug GameMaker Manual Bugs label Mar 11, 2024
@stuckie stuckie added this to the 2024.4 milestone Mar 12, 2024
@YYDan
Copy link
Collaborator

YYDan commented Mar 12, 2024

The manual is correct and the GMLSpec file for Feather appears correct also. However, the fnames file used by Syntax Errors (if Feather is disabled) does not think it's optional, so we'll fix that.

@YYDan YYDan added ide-bug Bugs with the GameMaker IDE and removed docs-bug GameMaker Manual Bugs labels Mar 12, 2024
@YYDan
Copy link
Collaborator

YYDan commented Mar 12, 2024

Hmmm... Okay, so Feather has mixed messages also:

image
vs
image

@YYDan YYDan changed the title array_contains_ext() - "matchall" is "optional" in documentation, but GM expects it Code Editor: array_contains_ext()'s "matchall" is optional in documentation, but GM expects it Mar 12, 2024
@DiasFranciscoA
Copy link

The problem is in fnames (as mentioned). Feather is not responsible for generation the bottom-of-the-window suggestion.. that suggestion depends only on fnames. Fixing fnames vs gmlspec mismatch.

@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Mar 12, 2024
@backYard321
Copy link
Author

@YYDan thanks! I still think it should be specified in the documentation whether matchall is true or false by default though.

YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Mar 13, 2024
@YYBartT
[General]Code Editor: array_contains_ext()'s "matchall" is optional i…
6a36dfb 
…n documentation, but GM expects it

YoYoGames/GameMaker-Bugs#4973
* Added the default value (false) to matchAll parameter description
* Linked to Offset and Length section on Array Functions page again (somehow this link can get lost for cross-references)
@YYBartT
Copy link

YYBartT commented Mar 13, 2024

Documented the default value of false of the matchAll parameter in the manual.

@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Mar 13, 2024
@backYard321
Copy link
Author

Documented the default value of false of the matchAll parameter in the manual.

Thank you!

@Emc1923
Copy link

Emc1923 commented Apr 8, 2024

Verified as of IDE v2024.400.0.533 Runtime v2024.400.0.552

@Emc1923 Emc1923 moved this from Ready for QA to Verified in Team Workload Apr 8, 2024
@YYBartT YYBartT mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiasFranciscoA DiasFranciscoA

Labels
ide-bug Bugs with the GameMaker IDE
Projects
Team Workload
Status: Verified
Milestone
2024.4
Development

No branches or pull requests
6 participants
@stuckie @YYDan @backYard321 @DiasFranciscoA @Emc1923 @YYBartT