Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing info on pr_trianglefan in docs #4586

Closed
Appsurdgames opened this issue Feb 1, 2024 · 3 comments
Closed

Missing info on pr_trianglefan in docs #4586

Appsurdgames opened this issue Feb 1, 2024 · 3 comments
Assignees
Labels
docs-bug GameMaker Manual Bugs

Comments

@Appsurdgames
Copy link

Description

On the manuel page about draw_primitive_begin, the constant pr_trianglefan is mentioned in the table, but the corresponding picture doesn't show what it does.

On the manual page about vertex_submit, the constant pr_trianglefan is again not shown in the picture, but it is also missing in the table.

Manual Link

https://manual.gamemaker.io/monthly/en/#t=GameMaker_Language%2FGML_Reference%2FDrawing%2FPrimitives%2Fdraw_primitive_begin.htm&rhsearch=pr_trianglefan&ux=search

@Appsurdgames Appsurdgames added the docs-bug GameMaker Manual Bugs label Feb 1, 2024
@ParodyKnaveBob
Copy link

Also, draw_primitive_begin lists the limitations of Windows, Xbox, and HTML5, but vertex_submit and draw_primitive_begin_texture don't. The manual ought to mention the same limits -- or the difference if there is one -- on the corresponding pages.

@attic-stuff
Copy link

attic-stuff commented Feb 1, 2024

(triangle fans look like triangle strips but each triangle share the first vertex. but trianglefans are a pretty unsupported primitive type all over the place—if gm gets a full implementation of webgpu for gmrt then there wont even be a trianglefan option cause its not in the spec at all. if i were gm i would update the manual to suggest those people looking to make a fan get comfy with a strip or list instead)

YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Mar 11, 2024
YoYoGames/GameMaker-Bugs#4586
* Added pr_trianglefan to the image showing primitive types
* Moved the Primitive Type Constants table to a snippet:
  * Added a more detailed description to every constant
  * Added a warning to pr_trianglefan
* vertex_submit/vertex_submit_ext:
  * Added extra note to Usage Notes list to mention conversion of pr_trianglefan to pr_trianglelist might occur
@YYBartT
Copy link

YYBartT commented Mar 11, 2024

Added an example of pr_trianglefan to the picture. Also added a warning note to pr_trianglefan in the Primitive Type Constant table to mention that it may not be supported on some platforms as well as a note on the vertex_submit and vertex_submit_ext pages to explain that these functions will convert the data in the vertex buffer if the submit is done using the pr_trianglefan primitive type (i.e. vertex_submit(vb, pr_trianglefan, tex)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-bug GameMaker Manual Bugs
Projects
None yet
Development

No branches or pull requests

4 participants