Drop support for ruby versions 2.4 and 2.5 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatilai
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
👍
I think so far in .rubocop.yml there were only exceptions to the defaults, but I can't remember any more. 😄
Would you mind also add a changelog entry for the dropped support of old Ruby and Terraform versions? And I think this requires a minor version bump.
| @@ -11,9 +11,9 @@ Offers a command-line helper tool, `tf` | |||
|
|
|||
| YleTf requires Terraform which can be installed according to their [instructions](https://www.terraform.io/intro/getting-started/install.html). On MacOS (and OSX) you can use [Homebrew](https://brew.sh/). You can also easily install and manage multiple versions of Terraform with [homebrew-terraforms](https://github.com/Yleisradio/homebrew-terraforms). | |||
|
|
|||
| YleTf supports Terraform versions from 0.9 on. Tested versions range from 0.11 to 1.0. | |||
| YleTf supports Terraform versions from 0.11 on. Tested versions range from 0.11 to 1.0. | |||
There was a problem hiding this comment.
I think everything should still work with v0.9. But I think it's fine not to promise anything, and hopefully no-one is still using such old versions anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.