Add Git LFS Support #180
Merged
Add Git LFS Support #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kareem zarka <kareem.zarka@huawei.com>
Closed
Yikun
requested changes
Jul 15, 2023
There was a problem hiding this comment.
Thanks for contributions! Great work!
I think it's OK to me to support it, but I'd more like to introduce with a option parameter like lfs.
By default, lfs is set to false. Only enable the addition lfs fetch/push, when user set lfs to true.
You can also test it by using something like
- name: Git LFS support
uses: kareemZarka/hub-mirror-action@support-lfs
with:
src: github/your_github_repo
dst: gitee/your_gitee_repo
dst_key: ${{ secrets.GITEE_PRIVATE_KEY }}
dst_token: ${{ secrets.GITEE_TOKEN }}
lfs: true
Pls also fix flake8 error and do a E2E test by above setting in your personal repo then paste the link.
Then I'd like to merge this.
In order to use it to enable LFS during mirror action. Signed-off-by: kareem zarka <kareem.zarka@huawei.com>
Signed-off-by: kareem zarka <kareem.zarka@huawei.com>
Implemented Git LFS handling, this includes: Installing LFS during clone/update operations, Pushing LFS objects during push operations. Signed-off-by: kareem zarka <kareem.zarka@huawei.com>
Yikun
approved these changes
Jul 18, 2023
|
@Yikun perfect! thank you!! |
|
@kareemZarka Thanks for contributions, merged. You can use below steps to have a test, if no more issue, I'd like to release a new version: v1.4 . |
|
@kareemZarka Any feedback about lfs feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Git LFS (Large File Storage)
_cloneand_updatemethods to fetch Git LFS objects during cloning and updating operations.pushmethod to push Git LFS objects along with regular repository contentCloses: #115