Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: additionalProperties can be a boolean value #138

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix: additionalProperties can be a boolean value #138

merged 1 commit into from
Jun 9, 2020

Conversation

sjaensch
Copy link
Contributor

@sjaensch sjaensch commented Jun 9, 2020 •
edited
Loading

The validation introduced in 2.7.0 did not consider this case, I've fixed it and added a test. The test fails with 2.7.0 but passes with this change.

Fixes #137.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.557% when pulling d0fe805 on fix-additionalproperties-bool-validation into fcc7604 on master.

@ymilki ymilki merged commit ab34510 into master Jun 9, 2020
@ngaya-ll ngaya-ll mentioned this pull request Jun 9, 2020
Open
sjaensch added a commit that referenced this pull request Jun 22, 2020
@sjaensch
Revert "Merge pull request #138 from Yelp/fix-additionalproperties-bo…
ff186cc 
…ol-validation"

This reverts commit ab34510, reversing
changes made to fcc7604.
@analogue analogue deleted the fix-additionalproperties-bool-validation branch September 28, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymilki ymilki ymilki approved these changes

@macisamuele macisamuele Awaiting requested review from macisamuele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validator errors when additionalProperties: false
3 participants
@sjaensch @coveralls @ymilki