Fix build by upgrading python #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some luisp strong opinions: * remove travis config * remove p-c-p and venv-update
looks like the tox here needs a list
bobokun
approved these changes
Dec 27, 2023
| @@ -24,7 +24,7 @@ def _get_metric_configs_for_service_by_cluster( | |||
| ) -> Dict[str, Dict[str, Any]]: # TODO: add type for rollback file config | |||
| configs = {} | |||
| for filename in get_rollback_files_from_soaconfigs(soa_dir, service=service): | |||
| with open(filename, 'r') as file: | |||
| with open(filename) as file: | |||
There was a problem hiding this comment.
Any reason for why we need to remove read-only when opening this file?
There was a problem hiding this comment.
pre-commit did this - likely because one of the hooks we have prefers that we don't re-state defaults?
danielpops
approved these changes
Dec 27, 2023
jfongatyelp
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some luisp strong opinions: