Tolerates reads of 128 bit X-B3-TraceId #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ps I just googled and looked at travis to figure out how to do this :) if there's anything not idiomatic please let me know. |
| @@ -103,11 +103,20 @@ def test_is_tracing_returns_what_tracing_percent_method_returns_for_rest( | |||
|
|
|||
|
|
|||
| def test_get_trace_id_returns_header_value_if_present(dummy_request): | |||
| dummy_request.headers = {'X-B3-TraceId': '17133d482ba4f605'} | |||
| dummy_request.headers = {'X-B3-TraceId': '48485a3953bb6124'} | |||
There was a problem hiding this comment.
changed the existing test, as it more clearly shows the generator isn't being used
1 similar comment
mjbryant
suggested changes
Sep 22, 2016
| dummy_request.registry.settings = { | ||
| 'zipkin.trace_id_generator': lambda r: '17133d482ba4f605', | ||
| } | ||
| assert '17133d482ba4f605' == request_helper.get_trace_id(dummy_request) | ||
| assert '48485a3953bb6124' == request_helper.get_trace_id(dummy_request) | ||
|
|
There was a problem hiding this comment.
Nit: could you add another blank line here? We enforce this via flake8, and indeed the travis build for this branch has failed. I believe make test is the "run-all-tests" invocation we generally use. :)
There was a problem hiding this comment.
done. thanks for the tip, too!
The first step of transitioning to 128bit `X-B3-TraceId` is tolerantly reading 32 character long ids by throwing away the high bits (any characters left of 16 characters). This allows the tracing system to more flexibly introduce 128bit trace id support in the future. Ex. when `X-B3-TraceId: 463ac35c9f6413ad48485a3953bb6124` is received, parse the lower 64 bits (right most 16 characters ex48485a3953bb6124) as the trace id.
mjbryant
approved these changes
Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step of transitioning to 128bit
X-B3-TraceIdis tolerantly reading 32 character long ids by throwing away the high bits (any characters left of 16 characters). This allows the tracing system to more flexibly introduce 128bit trace id support in the future.Ex. when
X-B3-TraceId: 463ac35c9f6413ad48485a3953bb6124is received, parse the lower 64 bits (right most 16 characters ex48485a3953bb6124) as the trace id.See openzipkin/b3-propagation#6