Ubuntu jammy actual support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oholiab
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Worth opening an issue after the fact to revert this once it's fixed upstream. Also possibly worth considering adding to the upstream issue a link to this PR so they can see what we had to do to get it working again, might help speed up resolution of the upstream problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the issues seem to be related to forward definition of things in kernel headers, so I decided to give a try to re-define the things which were causing trouble, and it seemed to have work. This is potentially a bit of a timebomb waiting to explode if anything changes in the kernel, but that's pretty much true for the entire tool implementation, so happy to live with the ticking.
While figuring this out, I noticed that we were wasteful with trailing whitespace on command lines, so
.strip().