improve cleanup of remote-run job resources #4039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
previously approved these changes
Apr 7, 2025
paasta_tools/kubernetes/bin/paasta_cleanup_remote_run_resources.py
Outdated
Show resolved
Hide resolved
paasta_tools/kubernetes/bin/paasta_cleanup_remote_run_resources.py
Outdated
Show resolved
Hide resolved
nemacysts
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paasta remote-runworks fine now, but I noticed that unless people callpaasta remote-run stopexplicitly, thejobresource would remain defined forever, even if the pod is terminated by the deadline being reached.Tackling that on two different angles:
ttl_seconds_after_finishedin the job spec should ensure that when the pod completes, the job gets cleaned up too by k8s itself.