Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yelp-clog and scribereader #3868

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

yaroliakh
Copy link
Contributor

@yaroliakh yaroliakh commented May 15, 2024

Based on the 7+ version changelog:

Deprecated support for logging bytes lines, emitting a DeprecationWarning if bytes lines are logged.
A future version of yelp-clog will only support str lines.
Removed support for the scribe protocol
Removed ScribeLogger, ScribeHandler, and ScribeMonkLogger classes.
Only Monk is supported as a backend for clog.
Removed the scribe readers
Removed NetCLogStreamReader and all other classes under the clog.readers module.
These classes are now available in the scribereader package.

none of the above seems to be used.

Removing the only reference I could find to deprecated clog.readers. Everything else should be already using Monk backend and should work without changes.

Smoke test:

paasta git:(u/yaro/OBSPLAT-1830_clog_upgrade) ✗
 -> python
Python 3.8.13 (default, Apr 19 2022, 02:32:06)
[GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from paasta_tools.utils import _log
>>> _log(service='statsite', line='test log 123', component='monitoring', level='debug', cluster='pnw-devc', instance='main')
[service statsite] test log 123

Copy link

@gkousouris gkousouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nemacysts
Copy link
Member

@yaroliakh did you also verify that paasta logs still works?

@@ -32,7 +32,7 @@ srv-configs==1.1.0
sticht[yelp_internal]==1.1.18
vault-tools==0.9.2
yelp-cgeom==1.3.1
yelp-clog==5.2.3
yelp-clog==7.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we'll want to add tenacity as well since that's now required by yelp-clog

(figuring this out was kinda annoying: i added the direct dependencies (i.e., things we import) into requirements-minimal.txt and copied the contents here to requirements.txt so that i could run check-requirements)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also some lines we can delete: https://fluffy.yelpcorp.com/i/wmSXXqXBvW1THmZPs5mfNGfF2cR9l69g.html is what i think we'd want as a final state

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've pinned deps and ran check-requirements for the following main dependencies:

yelp-clog
scribereader
clusterman-metrics
vault-tools
slo-transcoder
yelp-profiling
sticht[yelp_internal]==1.1.18

Not sure about deleting other deps, as I can see most of them being referenced in code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch - i somehow missed grepping for clusterman-metrics (which is maybe why my check-requirements said we could delete some deps)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also: big thank you for annotating these dependencies :)

@yaroliakh
Copy link
Contributor Author

@yaroliakh did you also verify that paasta logs still works?

seems to be working, as paasta logs is using scribereader interfaces to fetch logs, which hasn't changed with newer version
https://fluffy.yelpcorp.com/i/N59Cl7k0T3sCqmwjXxGPPjkHCmSwWtnh.html

@yaroliakh yaroliakh requested a review from nemacysts May 16, 2024 09:49
@@ -32,7 +32,7 @@ srv-configs==1.1.0
sticht[yelp_internal]==1.1.18
vault-tools==0.9.2
yelp-cgeom==1.3.1
yelp-clog==5.2.3
yelp-clog==7.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch - i somehow missed grepping for clusterman-metrics (which is maybe why my check-requirements said we could delete some deps)

@@ -32,7 +32,7 @@ srv-configs==1.1.0
sticht[yelp_internal]==1.1.18
vault-tools==0.9.2
yelp-cgeom==1.3.1
yelp-clog==5.2.3
yelp-clog==7.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also: big thank you for annotating these dependencies :)

@yaroliakh yaroliakh merged commit 679d535 into master May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants