Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use docker registry server's digest information for pushed spark images #3756

Conversation

danielpops
Copy link
Member

Problem

Because of containers/podman#14779, docker push has different behavior w.r.t. the local vs remote image digest value when run in privileged vs unprivileged mode. This was causing paasta spark run commands using --build to fail to allocate an executor node in unprivileged container mode because it was referring to an image digest that paasta couldn't find because it only exists on the devbox where paasta spark run is called.

Solution

Parse the message from the remote docker registry when running docker push during paasta spark run --build so that we always use the server version of the image digest as the source of truth.

Testing Done

Ran paasta spark run manually for both --pull and --build with this patch and confirmed the executor can be allocated and the jobs can complete.

@danielpops danielpops requested review from oholiab and piax93 December 18, 2023 17:07
Copy link
Contributor

@piax93 piax93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice workaround

Copy link
Contributor

@piax93 piax93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are a couple of unit tests that need to be fixed though

@danielpops
Copy link
Member Author

I guess there are a couple of unit tests that need to be fixed though

ah yeah I had some pre-commit shenanigans that was preventing me from running the tests locally, I will fix these ASAP

@danielpops danielpops force-pushed the u/dpopes/SECNESS-1845-unpriv-containers-spark-run-digest-fun branch from 30c909a to 004de4b Compare December 18, 2023 20:12
Copy link
Contributor

@piax93 piax93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@88manpreet 88manpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I assume the plan to push this is after Jan 1st, 2024.

Copy link

@oholiab oholiab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing <3

Let's get this merged ASAP now that we're in the new year so we can start doing more aggressive rollout to spark-heavy machines

@danielpops danielpops merged commit 169b283 into master Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants