Skip to content

Commit

Permalink
Merge pull request #3771 from Yelp/u/krall/check_autoscaler_max_insta…
Browse files Browse the repository at this point in the history
…nces_improvements

Minor improvements to check_autoscaler_max_instances
  • Loading branch information
EvanKrall authored Apr 1, 2024
2 parents 649109c + c80c16a commit 693c47f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/source/autoscaling.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ attempt to autoscale your service with the default autoscaling method.
``max_instances`` alerting
--------------------------

In order to make you aware of when your ``max_instances`` may be too low, causing issues with your service, paasta will send you alerts if all of the following conditions are true:
In order to make you aware of when your ``max_instances`` may be too low, causing issues with your service, Paasta will send you ``check_autoscaler_max_instances`` alerts if all of the following conditions are true:

* The autoscaler has scaled your service to ``max_instances``.

Expand Down
1 change: 1 addition & 0 deletions paasta_tools/check_autoscaler_max_instances.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ async def check_max_instances(
{
"page": False, # TODO: remove this line once this alert has been deployed for a little while.
"runbook": "y/check-autoscaler-max-instances",
"realert_every": 60, # The check runs once a minute, so this would realert every hour.
"tip": (
"The autoscaler wants to scale up to handle additional load"
" because your service is overloaded, but cannot scale any"
Expand Down

0 comments on commit 693c47f

Please sign in to comment.