Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene 9.9 upgrade #625

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Lucene 9.9 upgrade #625

merged 8 commits into from
Mar 5, 2024

Conversation

sarthakn7
Copy link
Contributor

@sarthakn7 sarthakn7 commented Mar 4, 2024

Changes:

  1. Updated codec to Lucene99 from Lucene95.
  2. Updated postings formats to Lucene99 and Completion99 from Lucene90 and Completion90.
  3. Make TermStates#build concurrent apache/lucene#12183 made TermStates.build() concurrent, due to which the build method now needs IndexSearcher instead of IndexReaderContext. [Backport] GITHUB-11838 Add api to allow concurrent query rewrite apache/lucene#12197 had added concurrent query rewrite and introduced rewrite(IndexSearcher), marking rewrite(IndexReader) as deprecated. I have replaced all rewrite(IndexReader) with rewrite(IndexSearcher) to keep it consistent and so that we can call TermStates.build() with IndexSearcher.
  4. MultiSegmentTest has a change in assertion because the toString changed, but not sure where. It might be due to change in the rewrite.
  5. Refactoring HNSW to use a new internal FlatVectorFormat apache/lucene#12729 refactored HNSW to use internal FlatVectorFormat due to which the toString is different.
  6. SegmentInfo has a new hasBlocks parameter in constructor, so set it to false in BucketedTieredMergePolicyTest.
  7. Removed IndexReader parameter from FilterFunction.doRewrite() since it was unused.

Example plugin test fails because the jar is not uploaded yet.

@sarthakn7 sarthakn7 marked this pull request as ready for review March 4, 2024 17:40
@sarthakn7 sarthakn7 merged commit 353f6bc into 1.0.0-SNAPSHOT Mar 5, 2024
1 check failed
@sarthakn7 sarthakn7 deleted the sarthakn_lucene_9.9_upgrade branch March 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants