Add office filter to leaderboard #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdog
reviewed
Mar 21, 2018
| selected_dept=department, | ||
| selected_timespan=timespan, | ||
| selected_timespan=timespan, selected_office=office, | ||
| org_title=config.ORG_TITLE, |
There was a problem hiding this comment.
I wonder if org_title is still being used? If not it should be removed here and in the config.
| @@ -32,6 +32,15 @@ <h1>Lovers of the Week</h1> | |||
| {% endfor %} | |||
| </select> | |||
| </div> | |||
| <div class="form-group"> | |||
| <label class="sr-only" for="office">Department</label> | |||
There was a problem hiding this comment.
I assume this should be Office not Department?
| lovers.append((employee_key, c.sent_count)) | ||
| else: | ||
| employee = employee_key.get() | ||
| if ( |
There was a problem hiding this comment.
Not blocking but I think this could need a comment saying what condition we are looking for to append an employee to the list.
There was a problem hiding this comment.
Maybe even better to extract this into a function with a little docstring to keep things DRY. Thoughts?
| lovees.append((employee_key, c.received_count)) | ||
| else: | ||
| employee = employee_key.get() | ||
| if ( |
There was a problem hiding this comment.
Not blocking but I think this could need a comment saying what condition we are looking for to append en employee to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add office filter to leaderboard