Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy_docs.sh #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mannyluvstacos
Copy link

@mannyluvstacos mannyluvstacos commented Jan 1, 2022

This PR updates

  • the remote name to https://github/com/Yelp/graphql-guidelines.git
  • the LOCALBRANCHNAME from master to main

to solve the build error that is currently seen in GitHub Actions
source

@mannyluvstacos
Copy link
Author

mannyluvstacos commented Jan 1, 2022

Hi Mark (@magicmark) and Peter (@PeterDraex)!

When you have a moment, I'd love a review on this PR to hopefully help with the GitHub Actions Build/Deploy failure.
Thank you for writing these guidelines!


🤔 I think the only part that may need an update is the update of using main instead of master as I am wondering if the localbranch relative to the build is using master.

I'd be more than happy to update!
Please let me know :)


I've read the Shopify Guidelines (which we have applied at my current employer) and when I saw Yelp's Guidelines out I was interested to see how y'all were doing things!

@PeterDraex
Copy link
Contributor

Hi @mannyluvstacos,

line 22 on your screenshot says that branch master is being used locally right now. I think we need to change it to main for your changes to work. (And so the build won't stop working in a future version a git.)

git init --initial-branch=main

Disclaimer: I don't work for Yelp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants