Make is_likely_id_string More Strict #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 489
Problem:
is_likely_id_string
regex can eliminate true positives by mistake.id
like the namedavid
followed by a non-letter/non-numeric character will matchSolution:
id
identifier however we lose out on the other typical id_string identifiers likemyid
,userid
etc._id
identifier and this can exist in the middle of a string