Support for C, C++ and C# secrets in Keyword plugin #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @domanchi, what do you think about that? Thank you! |
domanchi
approved these changes
Apr 8, 2021
detect_secrets/plugins/keyword.py
Outdated
| denylist=DENYLIST_REGEX, | ||
| square_brackets=SQUARE_BRACKETS, | ||
| optional_whitespace=OPTIONAL_WHITESPACE, | ||
| secret=SECRET, | ||
| ), | ||
| flags=re.IGNORECASE, | ||
| ) | ||
| FOLLOWEB_BY_OPTIONAL_ASSIGN_QUOTES_REQUIRED_REGEX = re.compile( |
There was a problem hiding this comment.
Suggested change
| FOLLOWEB_BY_OPTIONAL_ASSIGN_QUOTES_REQUIRED_REGEX = re.compile( | |
| FOLLOWED_BY_OPTIONAL_ASSIGN_QUOTES_REQUIRED_REGEX = re.compile( |
There was a problem hiding this comment.
Oh yes, thank you for report it! It's corrected
domanchi
approved these changes
Apr 9, 2021
killuazhu
pushed a commit
to IBM/detect-secrets
that referenced
this pull request
May 11, 2021
* Fix divide by zero bug Fixes user reported bug (see [Slack thread](https://ibm-whitewater.slack.com/archives/CDMGJ9QG2/p1620408289067500)) * Fix safety check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces some regex in the KeywordDetector plugin to detect secrets in C, C++ and C# files. Some examples of this secrets are:
C:
char* password = "foo";char password[25] = "foo";C++:
string secret = "foo";std::string secret("foo");secret.assign("foo",17);C#:
string password = @"foo";string password = "foo";string password[] = "foo";