-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High Entropy string matchers have false positives on uuids. #250
Comments
We might be able to add this to #245, as it has recently come up for us as well. On a private branch, I had added if len(result) == 36:
UUID_RE = re.compile(
r'^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89AB][0-9a-f]{3}-[0-9a-f]{12}$',
re.IGNORECASE,
)
if UUID_RE.match(result):
continue in this area detect-secrets/detect_secrets/plugins/high_entropy_strings.py Lines 92 to 97 in b21c5f8
recently, but I didn't fully flesh it out. |
Could you give an example UUID for posterity @conartist6? I realized on my private branch I had |
This is a v4 uuid. |
Thanks! :) |
* Publish art too * Dummy... not echo, but action
* Publish art too * Dummy... not echo, but action
This should have been closed a while ago. In v1, this is added as a filter as well. |
It should be possible to identify random UUIDs which, though they are hex high entropy strings, are generally not secrets. The combination of length, string formatting, and the version bit should be sufficient to match UUIDs, and at least offer the user a configuration option to consider them false positives and quash reporting on them.
The text was updated successfully, but these errors were encountered: