Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document audit --diff functionality in CONTRIBUTING.md #190

Closed
domanchi opened this issue Jun 6, 2019 · 2 comments
Closed

document audit --diff functionality in CONTRIBUTING.md #190

domanchi opened this issue Jun 6, 2019 · 2 comments
Assignees
@domanchi

Comments

@domanchi
Copy link
Contributor

domanchi commented Jun 6, 2019

There's a super cool feature that helps plugin developers create plugins easier, by comparing to a known baseline.

$ detect-secrets audit --diff old_baseline.json new_baseline.json

We should probably document this, for better discoverability and developer happiness.
@domanchi domanchi self-assigned this Jun 6, 2019
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue May 28, 2020
@justineyster
Verification for Artifactory tokens (Yelp#190)
dc723ab 
* Verification for Artifactory tokens

Supports git-defenders/detect-secrets-discuss#173

* Remove 443

* Extract artifactory url

* Address @xianjun comments
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Jul 9, 2020
@justineyster
Verification for Artifactory tokens (Yelp#190)
b7f2fca 
* Verification for Artifactory tokens

Supports git-defenders/detect-secrets-discuss#173

* Remove 443

* Extract artifactory url

* Address @xianjun comments
@KevinHock
Copy link
Collaborator

KevinHock commented Jul 23, 2020 •
edited
Loading

Same for --audit display, I think since we're probably never gonna get around to it, that we can just paste in the --help output to the README. Our stance was that if someone wants to find these things --help is easy enough but I want to say I've seen 2+ GitHub comments of people struggling with what could have been alleviated by having --help in the README.

killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Sep 17, 2020
@justineyster
Verification for Artifactory tokens (Yelp#190)
9313949 
Supports git-defenders/detect-secrets-discuss#173

Fix Artifactory validation failure case (Yelp#195)

Closes git-defenders/detect-secrets-discuss#207

Fix Artifactory regex to no longer match assignment character (Yelp#197)
@domanchi
Copy link
Contributor Author

Wrote much more detailed descriptions in https://github.com/Yelp/detect-secrets/blob/pre-v1-launch/docs/audit.md. Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domanchi domanchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinHock @domanchi