fixed issue where multiple weapons of same type was not showing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add to the PR an example file that trigger the issue ? |
|
I’m off to bed now. I can do it tomorrow or you can replicate it yourself easily. Just create a new army roster in bs. Create a bedroom army and don’t worry about the detachment. When you get to choose your units select the "canoptek tomb stalker". Then render the view so you can see its stats. Pay close attention to the fact it has TWO weapons. Save the ros file with the one unit. After you upload it you are asked to confirm the units. You can see here Thst there will only be one weapon. Now repeat everything again but with my code changes and it will show correctly with 2 guns
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Gabriel Laskar ***@***.***>
Sent: Friday, January 21, 2022 11:14:24 PM
To: Yellow-Man-Code/BS2TTS ***@***.***>
Cc: powershellwhizz ***@***.***>; Author ***@***.***>
Subject: Re: [Yellow-Man-Code/BS2TTS] fixed issue where multiple weapons of same type was not showing (PR #1)
Could you add to the PR an example file that trigger the issue ?
—
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMJEZ2RNW7HPYIOYPPHAEV3UXFE2BANCNFSM5MOS47JQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Lol auto correct on my phone. It was meant to say"create a necro army"
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Graham Allen ***@***.***>
Sent: Saturday, January 22, 2022 12:02:09 AM
To: Yellow-Man-Code/BS2TTS ***@***.***>; Yellow-Man-Code/BS2TTS ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [Yellow-Man-Code/BS2TTS] fixed issue where multiple weapons of same type was not showing (PR #1)
I’m off to bed now. I can do it tomorrow or you can replicate it yourself easily. Just create a new army roster in bs. Create a bedroom army and don’t worry about the detachment. When you get to choose your units select the "canoptek tomb stalker". Then render the view so you can see its stats. Pay close attention to the fact it has TWO weapons. Save the ros file with the one unit. After you upload it you are asked to confirm the units. You can see here Thst there will only be one weapon. Now repeat everything again but with my code changes and it will show correctly with 2 guns
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Gabriel Laskar ***@***.***>
Sent: Friday, January 21, 2022 11:14:24 PM
To: Yellow-Man-Code/BS2TTS ***@***.***>
Cc: powershellwhizz ***@***.***>; Author ***@***.***>
Subject: Re: [Yellow-Man-Code/BS2TTS] fixed issue where multiple weapons of same type was not showing (PR #1)
Could you add to the PR an example file that trigger the issue ?
—
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMJEZ2RNW7HPYIOYPPHAEV3UXFE2BANCNFSM5MOS47JQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Here is a sample that illustrate the issue (escuse the extension to please github) |
|
@GabrielL hey buddy, what is your name on the discord server? |
|
hey @GabrielL what is your handle of the discord server? |
GabrielL
reviewed
Feb 5, 2022
what they do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in discord, the issue is that BS organises the data via units so a unit with 6 men has 6 guns. When this is applied to a model in TTS it shows as 6 guns. So to fix this, the original dev just set it so that each MODEL would always get one gun. This had the adverse effect of stripping legitimate duplicate guns. This code fix fixes all of that by adding a new paramater called "number" which passes down the unit number all the to the function which then creates the weapons. At this point it looks at how many weaapons there are then divides it by the unit number which was passed down. Example, 6 man unit they have 2 guns each but in BS you just see 12 guns. My change now, passes the unit number 6 to the function which adds the weapons, It counts 12 guns and divides by 6 units meaning they have 2 guns each, as intended.