Include missing libmicroros references #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libmicroros for DX200 and YRC1000u were not being included in the build, so the binaries were far smaller than they should have been and were missing necessary code.
ted-miller
reviewed
Feb 21, 2025
| @@ -268,9 +268,15 @@ | |||
| <None Include="..\libmicroros_yrc1000_jazzy\libmicroros.yrcLib_jazzy"> | |||
| <Filter>MotoPlus Libraries\micro-ROS</Filter> | |||
| </None> | |||
| <None Include="..\doc\network_configuration.md"> | |||
| <None Include="..\doc\network_configuration.md"> | |||
There was a problem hiding this comment.
whitespace is auto-formatted by VS
ted-miller
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was preparing for the 0.2.0 release, and I took a look at the binaries from the batch build for DX200 and YRC1000 and realized that they were far smaller than they should have been and were missing necessary code. I figured out that it was because
libmicroros.dnLib_jazzyandlibmicroros.yrcmLib_jazzywere missing. They have been building properly, but wouldn't have run.