Use native json pretty printing if available #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ( function_exists('wsh_pretty_json') ) { | ||
| $output = wsh_pretty_json($output); | ||
| $output = ''; | ||
| if ( defined('JSON_PRETTY_PRINT') && JSON_PRETTY_PRINT ) { |
There was a problem hiding this comment.
Is the && JSON_PRETTY_PRINT part necessary? I think defined() already covers the existence check. It is also possible (though unlikely) that in a future PHP version the value of the constant could be something falsy like 0, which would make the condition fail.
There was a problem hiding this comment.
You are of course completely right, must not have been properly awake yet when I did this ;-)
YahnisElsts
added a commit
that referenced
this pull request
Sep 10, 2014
Use native JSON pretty printing if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON_PRETTY_PRINTconstant has been available since PHP5.4, so let's use it.