Merge pull request #23 from jrfnl/Bug-fix-cache

Bug fix: Prevent lots of unnecessary metadata cache writes.
YahnisElsts · Jan 7, 2015 · 5068727 · 5068727
2 parents 2322275 + 18138dd
commit 5068727
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/includes/Wpup/Package.php b/includes/Wpup/Package.php
@@ -89,12 +89,13 @@ public static function fromArchive($filename, $slug = null, Wpup_Cache $cache =
 				throw new Wpup_InvalidPackageException( sprintf('The specified file %s does not contain a valid WordPress plugin or theme.', $filename));
 			}
 			$metadata['last_updated'] = gmdate('Y-m-d H:i:s', $modified);
+
+			//Update cache.
+			if ( isset($cache) ) {
+				$cache->set($cacheKey, $metadata, self::$cacheTime);
+			}
 		}
 
-		//Update cache.
-		if ( isset($cache) ) {
-			$cache->set($cacheKey, $metadata, self::$cacheTime);
-		}
 		if ( $slug === null ) {
 			$slug = $metadata['slug'];
 		}