Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A morbillion ImGui features #349

Merged
merged 5 commits into from
Sep 28, 2024
Merged

A morbillion ImGui features #349

merged 5 commits into from
Sep 28, 2024

Conversation

UncraftedName
Copy link
Contributor

@UncraftedName UncraftedName commented Sep 20, 2024 •
edited
Loading

GUI Changes:

  • Added QoL & cheat tab
  • Added IHUD/JHUD tabs in addition to text HUD tab
  • Added misc section to drawing tab
  • Updated spt_hud_velocity HUD cvar to be a drop-down instead of a checkbox
  • The tab callbacks in the main window are now in a child window (independent scrolling region)

Internal changes:

  • Added RTA time to timer feature (this is so that you can tell if the feature is actually on when using it in ImGui)
  • Removed the 'open' bool param from the main window ImGui callbacks - it's really inconvenient if the user has to check for it all the time and doesn't use it 95% of the time

The distinction between the QoL & the Cheats tab is pretty muddy. Some of that may be organized differently or shifted around in the future ¯\(ツ)/¯.

Independent scrolling region:
image

QoL tab:
image

Cheats tab:
image

@UncraftedName UncraftedName force-pushed the imgui-qol-cheats branch 6 times, most recently from 7b2fae1 to ae6cdf7 Compare September 24, 2024 00:44
@UncraftedName
Remove open param from imgui tab/section callbacks
6986a91 
Also simplify tab/section logic for user callback registration
@UncraftedName
Add a bunch of QoL/cheat features to imgui
6c01162 
- Add QoL & cheat tab

- Add IHUD/JHUD tabs in addition to text HUD tab

- Add misc section to drawing tab

- Add RTA time to timer feature
@UncraftedName
Simplify main window callback & put tab callback in independant scrol…
aa1ea30 
…ling region
@UncraftedName
Update hud callback for spt_hud_velocity
0701bf8
@UncraftedName UncraftedName marked this pull request as ready for review September 27, 2024 06:48
lipsanen
lipsanen reviewed Sep 27, 2024
View reviewed changes
spt/features/collision_group.cpp
ImGui::SameLine();
SptImGui::CmdHelpMarkerWithName(y_spt_set_collision_group_command);
});
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be better with a dropdown with the names of the collision groups? more effort though

@lipsanen
Copy link
Collaborator

other than that looks good to me

@UncraftedName
Copy link
Contributor Author

As you wish
image

(I'm trusting the SDK values here)

@lipsanen lipsanen merged commit 8fbb3a3 into YaLTeR:master Sep 28, 2024
8 checks passed
@lipsanen
Copy link
Collaborator

tyvm

@UncraftedName UncraftedName deleted the imgui-qol-cheats branch September 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipsanen lipsanen lipsanen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UncraftedName @lipsanen