-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bxt_tas_editor_show_from_last_frames #442
Add bxt_tas_editor_show_from_last_frames #442
Conversation
I think camera should be cut off as well. Let me make that change. |
This should be good. One weird thing with camera is that stationary green line will show up as blue if segment is too short, but it is green underneath and can be smoothed just fine. |
BunnymodXT/triangle_drawing.cpp
Outdated
@@ -1610,6 +1623,13 @@ namespace TriangleDrawing | |||
Vector last_shown_view_angle_origin; | |||
|
|||
for (size_t frame = 1; frame < player_datas.size(); ++frame) { | |||
if (frame < start_frame) { | |||
// Match inner advancing when skip showing some frame bulks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand this comment, could you rephrase it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BunnymodXT/BunnymodXT/triangle_drawing.cpp
Line 1750 in 6efb3f6
if (frame == frame_bulk_starts[next_frame_bulk_start_index]) { |
From here, it draws perpendicular lines and some basic interactions. Due to how everything is structured, if I don't change next_frame_bulk_start_index
when skipping showing the current frame (meaning not going over that line), there will be no perpendicular lines and basic interactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Incrementing next_frame_bulk_start_index
when frames are skipped to correctly render perpendicular line."
Thanks |
Camera lines still show up normally.