Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bxt_tas_editor_show_from_last_frames #442

Merged
merged 6 commits into from
Jun 24, 2023

Conversation

khanghugo
Copy link
Contributor

Camera lines still show up normally.

@khanghugo
Copy link
Contributor Author

I think camera should be cut off as well. Let me make that change.

@khanghugo khanghugo marked this pull request as draft May 5, 2023 00:46
@khanghugo
Copy link
Contributor Author

khanghugo commented May 5, 2023

This should be good. One weird thing with camera is that stationary green line will show up as blue if segment is too short, but it is green underneath and can be smoothed just fine.

@khanghugo khanghugo marked this pull request as ready for review May 5, 2023 01:15
@@ -1610,6 +1623,13 @@ namespace TriangleDrawing
Vector last_shown_view_angle_origin;

for (size_t frame = 1; frame < player_datas.size(); ++frame) {
if (frame < start_frame) {
// Match inner advancing when skip showing some frame bulks
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand this comment, could you rephrase it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (frame == frame_bulk_starts[next_frame_bulk_start_index]) {

From here, it draws perpendicular lines and some basic interactions. Due to how everything is structured, if I don't change next_frame_bulk_start_index when skipping showing the current frame (meaning not going over that line), there will be no perpendicular lines and basic interactions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Incrementing next_frame_bulk_start_index when frames are skipped to correctly render perpendicular line."

BunnymodXT/cvars.hpp Outdated Show resolved Hide resolved
@YaLTeR YaLTeR merged commit b76702b into YaLTeR:master Jun 24, 2023
@YaLTeR
Copy link
Owner

YaLTeR commented Jun 24, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants