Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Added forgotten parameter #16

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Added forgotten parameter #16

merged 3 commits into from
Mar 23, 2021

Conversation

miloit
Copy link
Contributor

@miloit miloit commented Mar 21, 2021

Added forgotten parameter

@miloit miloit requested a review from zehnm March 22, 2021 19:24
Copy link
Member

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please check @martonborzak if there's anything else required when adding a new command enum. For the future: wouldn't it be better to add new enums in the end? Otherwise this will be a breaking change.
Note to myself & @martonborzak: with the other recent interface changes it's no longer backwards compatible and we have to release a 1.0 version as soon as I have the dependency checks in the plugin loader. Otherwise the app will just crash if there's another plugin compiled with an older intg library!

Copy link
Member

@martonborzak martonborzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's all for commands. For features you need to add it to config-schema.json as well.

@zehnm zehnm merged commit 262a50a into YIO-Remote:master Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants