Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Feature/custom buttons remote #12

Merged
merged 10 commits into from
Jan 11, 2021

Conversation

nikos1988
Copy link
Contributor

PR 2/3

@martonborzak martonborzak marked this pull request as draft September 4, 2020 18:52
Copy link
Member

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Please add a pull request description, what this changes are for. Especially for the new sendCustomCommand method.

src/yio-plugin/integration.cpp Outdated Show resolved Hide resolved
src/yio-interface/integrationinterface.h Outdated Show resolved Hide resolved
src/yio-interface/integrationinterface.h Outdated Show resolved Hide resolved
src/yio-interface/integrationinterface.h Outdated Show resolved Hide resolved
@nikos1988
Copy link
Contributor Author

Hi, could you take another look at the two commits i added. I think supporting the custom features is possible with minimal changes to the addAvailableEntity method. (Added customFeatures string list parameter with empty list as default)

@zehnm
Copy link
Member

zehnm commented Sep 6, 2020

@nikos1988 I'll have a look tomorrow. I didn't see the 3rd part of your PR, maybe I just missed it. Shouldn't there be an implementation in an integration plugin, e.g. home-assistant, openhab or homey?
I saw a mqtt reference in your other PR. What's that for, an upcoming mqtt integration?

@nikos1988
Copy link
Contributor Author

@nikos1988 I'll have a look tomorrow. I didn't see the 3rd part of your PR, maybe I just missed it. Shouldn't there be an implementation in an integration plugin, e.g. home-assistant, openhab or homey?
I saw a mqtt reference in your other PR. What's that for, an upcoming mqtt integration?

Hi, the 3rd PR was for the web-configurator to add the custom features. I have developed an mqtt integration, but this is currently customized for my own needs. Maybe i can release something better suited for everyone in the future.

@zehnm
Copy link
Member

zehnm commented Sep 7, 2020

I have developed an mqtt integration, but this is currently customized for my own needs.

Maybe we can join our efforts: I'm working on a webhook integration which would be very easy to extend with mqtt:
https://github.com/zehnm/integration.webhook
I've already thought of enhancing it with mqtt, since most logic could be used for webhook & mqtt, but haven't had time to continue working on it.

@zehnm
Copy link
Member

zehnm commented Jan 11, 2021

Since there hasn't been any activity for a while and the PR looks ready, I'm going to change the state to ready and review it.

@zehnm zehnm marked this pull request as ready for review January 11, 2021 20:26
@zehnm zehnm merged commit f88065e into YIO-Remote:master Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants