Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ds-1300] Fix deprecation code (once and cookie) in js files #94

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[Ds-1300] Fix deprecation code (once and cookie) in js files #94

merged 1 commit into from
Jan 12, 2024

Conversation

aleevas
Copy link

@aleevas aleevas commented Jan 11, 2024

Related Issue/Ticket:
DS-1300

Steps to test:

  • Go to the site with virtual Y that uses as the default theme Rose or Lilly
  • Open Dev Tools
  • Verify that you don't see js-errors in the console
    image

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@aleevas aleevas marked this pull request as ready for review January 11, 2024 15:50
@svicervlad svicervlad merged commit 5eceb28 into YCloudYUSA:main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svicervlad svicervlad svicervlad approved these changes

@rollki rollki rollki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleevas @svicervlad @rollki