Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-1204] Set default value for creator_plugin options of the eventseries config #91

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[DS-1204] Set default value for creator_plugin options of the eventseries config #91

merged 2 commits into from
Dec 7, 2023

Conversation

aleevas
Copy link

@aleevas aleevas commented Dec 7, 2023

DS-1204

Steps to test:

  • log. in as a CMS user
  • install VY Log and Field UI modules
  • go to. /admin/structure/events/series/types/eventseries_type/live_stream/edit/form-display and enable Hosts name field
  • go to the event series
  • edit any event series > add instructor in Hosts name field and click on the Save button

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@aleevas aleevas marked this pull request as ready for review December 7, 2023 16:11
podarok
podarok reviewed Dec 7, 2023
View reviewed changes
modules/openy_gc_storage/config/install/recurring_events.eventseries.config.yml
@@ -12,3 +12,4 @@ threshold_warning: 1
threshold_count: 200
threshold_message: 'Saving this series will create up to @total event instances. This could result in memory exhaustion or site instability. Please try again with a smaller date range.'
threshold_prevent_save: 0
creator_plugin: 'recurring_events_eventinstance_recreator'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need hook update for this config

podarok
podarok requested changes Dec 7, 2023
View reviewed changes
Copy link

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need hook update for this config

@podarok podarok merged commit 0656ce3 into YCloudYUSA:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podarok podarok podarok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleevas @podarok