Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Builder Compatibility #29

Merged
merged 10 commits into from
Apr 19, 2023
Merged

Layout Builder Compatibility #29

merged 10 commits into from
Apr 19, 2023

Conversation

Sardis93
Copy link

@Sardis93 Sardis93 commented Mar 9, 2023

Check not only for Paragraph but Block during Virtual Y Login Rediret, ensuring compatibility with Layout Builder.

Related Issue/Ticket:

PLEASE CHECK BASE BRANCH FOR YOUR PR
ONLY urgent and approved fixes for point release should go to master branch

(Replace this line with a link to the related GitHub issue on YCloudYUSA/yusaopeny_gated_content or your own ticketing system)

Steps to test:

  • Enable Layout Builder module.
  • Enable openy_gc_auth_example module.
  • Create Content Type for Layout Builder.
  • Create node and add Virtual Y Content Block via Layout Builder.
  • Create another node with Virtual Y Login Block via Layout Builder.
  • Set up Virtual Y Landing Page url and Virtual Y Login Landing Page url fields on settings page: admin/openy/virtual-ymca
  • Navigate to the page with Virtual Y Content Login block and hit Enter Virtual Y button.
  • Observe redirect to the node with Virtual Y Content Block

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

id: gated_content_login
label: 'Virtual Y Content Login'
revision: 0
description: 'A block to display Virtual Y Content login paragraph.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'A block to display Virtual Y Content login paragraph.'
description: 'A block to display Virtual Y Content login.'

Copy link
Collaborator

@anpolimus anpolimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your approach, but this requests needs to be changed.
We are trying to get rid of paragraphs in the future.
This means that having a paragraph inside the block is not the way how we want to render VY in the future.
We need a simple custom block that renders an app inside it's template.
It will make your check code a little bit complex but module will be less dependant on paragraphs.

@froboy
Copy link

froboy commented Mar 15, 2023

@podarok it sounds like this has some work to be done before it's ready, so I don't think it should block the release.

Copy link
Collaborator

@anpolimus anpolimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sardis93 in this project we try to create a new block for each widget since we want to have a base for future improvements and comfortable use on the LB custom block level.
Please, return VY block back.

Copy link

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing to get merged

@Sardis93
Copy link
Author

Hey, @podarok !

The alter hook you suggest to document is not a new hook i added, it's the one we used from before and it is already in the api.php file. Please, see the link:

https://github.com/YCloudYUSA/yusaopeny_gated_content/blob/master/openy_gated_content.api.php#L22

@podarok podarok merged commit 3631765 into YCloudYUSA:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants