-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout Builder Compatibility #29
Conversation
…t, ensuring compatibility with Layout Builder.
id: gated_content_login | ||
label: 'Virtual Y Content Login' | ||
revision: 0 | ||
description: 'A block to display Virtual Y Content login paragraph.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: 'A block to display Virtual Y Content login paragraph.' | |
description: 'A block to display Virtual Y Content login.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your approach, but this requests needs to be changed.
We are trying to get rid of paragraphs in the future.
This means that having a paragraph inside the block is not the way how we want to render VY in the future.
We need a simple custom block that renders an app inside it's template.
It will make your check code a little bit complex but module will be less dependant on paragraphs.
@podarok it sounds like this has some work to be done before it's ready, so I don't think it should block the release. |
…ogin templates & Virtual Y App block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sardis93 in this project we try to create a new block for each widget since we want to have a base for future improvements and comfortable use on the LB custom block level.
Please, return VY block back.
…th Virtual Y Login block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing to get merged
Hey, @podarok ! The alter hook you suggest to document is not a new hook i added, it's the one we used from before and it is already in the api.php file. Please, see the link: https://github.com/YCloudYUSA/yusaopeny_gated_content/blob/master/openy_gated_content.api.php#L22 |
Check not only for Paragraph but Block during Virtual Y Login Rediret, ensuring compatibility with Layout Builder.
Related Issue/Ticket:
PLEASE CHECK BASE BRANCH FOR YOUR PR
ONLY urgent and approved fixes for point release should go to master branch
(Replace this line with a link to the related GitHub issue on YCloudYUSA/yusaopeny_gated_content or your own ticketing system)
Steps to test:
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_N
or other means.team in Slack