Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-121] There is gap below the menu section #24

Merged
merged 1 commit into from
Dec 23, 2022
Merged

[DS-121] There is gap below the menu section #24

merged 1 commit into from
Dec 23, 2022

Conversation

andreyzb
Copy link

Related Issue/Ticket: There is gap below the menu section

DS-121

Steps to test:

  • See description for the ticket

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@andreyzb
Copy link
Author

Issue appears when Site search was not enabled on for the Virtual Y installation, then there is no Search button in the top menu. Search button added extra height to the menu, and when it is missing we can see the gap described in the ticket.

@podarok podarok merged commit 84daa8b into YCloudYUSA:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants