[DS-97] Instructor Reference field is not displayed on Schedule/Teasers #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer patch is required for proper inheritance
podarok
requested changes
Oct 25, 2022
src/Controller/EventsController.php
Outdated
| @@ -8,6 +8,7 @@ | |||
| use Drupal\Core\Datetime\DrupalDateTime; | |||
| use Drupal\Core\Extension\ModuleHandlerInterface; | |||
| use Drupal\openy_gated_content\VirtualYAccessTrait; | |||
| use Drupal\taxonomy\Entity\Term; | |||
There was a problem hiding this comment.
We need to add dependency to taxonomy module
There was a problem hiding this comment.
This use was outdated and was replaced with the entity queries. I've removed it instead.
src/Controller/EventsController.php
Outdated
| public function getInheritedFieldLabels(int $id, string $field): array | ||
| { | ||
| // Get the field values from the parent series. | ||
| $series_values = \Drupal::service('entity_type.manager') |
There was a problem hiding this comment.
Let's use Dependency Injection and avoid static calls for better container performance and cacheability
src/Controller/EventsController.php
Outdated
| ->{$field} | ||
| ->referencedEntities(); | ||
| // Get the field values from the instance. | ||
| $instance_values = \Drupal::service('entity_type.manager') |
There was a problem hiding this comment.
Let's use Dependency Injection and avoid static calls for better container performance and cacheability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Ticket:
PLEASE CHECK BASE BRANCH FOR YOUR PR
ONLY urgent and approved fixes for point release should go to master branch
https://yusa.atlassian.net/browse/DS-97
Instructor data from
field_gc_instructor_referencewas not previously displaying on event teasers or the VY schedule page, as per #12. With this change, Instructors from that field will be used in the display and if the field is not populated any data in the deprecatedHost's Namefield will be used.Inheritance should go as follows:
Steps to test:
Host's Namefield you may need to re-enable the field atadmin/structure/events/instance/types/eventinstance_type/virtual_meeting/edit/form-displayadmin/structure/events/instance/types/eventinstance_type/live_stream/edit/form-displayadmin/structure/events/series/types/eventseries_type/virtual_meeting/edit/form-displayadmin/structure/events/series/types/eventseries_type/live_stream/edit/form-displayQuality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_Nor other means.team in Slack