Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem with hidden content. #101

Merged

Conversation

oleh-rymar
Copy link

Related Issue/Ticket:

PLEASE CHECK BASE BRANCH FOR YOUR PR
ONLY urgent and approved fixes for point release should go to master branch

(Replace this line with a link to the related GitHub issue on YCloudYUSA/yusaopeny_gated_content or your own ticketing system)

Steps to test:

  • First do this
  • Then do this (and look at this great screenshot).
  • Finally observe the issue is resolved.

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@oleh-rymar
Copy link
Author

@anpolimus

Please, review.

#102

You can find a more detailed description of the problem here.

@froboy
Copy link

froboy commented Jun 14, 2024

@oleh-rymar thanks for this. I've confirmed it fixes things for Layout Builder pages. Can you confirm that removing the library doesn't negatively affect non-lb pages, since they get VY through paragraphs instead of blocks?

@oleh-rymar
Copy link
Author

@froboy

Can you confirm that removing the library doesn't negatively affect non-lb pages, since they get VY through paragraphs instead of blocks?

Confirmed. Everything is working fine.

@froboy froboy merged commit 38de3b2 into YCloudYUSA:main Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants