Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openy_features with Utility Menu #216

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: openy_features with Utility Menu #216

merged 1 commit into from
Sep 24, 2024

Conversation

podarok
Copy link

@podarok podarok commented Sep 17, 2024

Original Issue, this PR is going to fix: https://yusaslackinstance.slack.com/archives/C03E6SQQ0Q5/p1726582566750179?thread_ts=1726582450.933909&cid=C03E6SQQ0Q5

Installing drupal/diff (1.7.0): Extracting archive
  - Installing drupal/ckeditor5_font (1.1.2-beta1): Extracting archive
  - Installing open-y-subprojects/openy_features (3.3.3): Extracting archive
  - Installing open-y-subprojects/openy_daxko_gxp_syncer (1.2.1): Extracting archive
  - Installing open-y-subprojects/common_scss (dev-main 6209485): Extracting archive

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use main branch. We'll tag for release if the bug is critical ASAP or tag for release next bug fix release until the critical issue arrives.

Steps for review

  • Please provide steps for review here.

General checks

Thank you for your contribution!

@podarok podarok self-assigned this Sep 17, 2024
@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4929/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4929/install.php

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4929/

@podarok
Copy link
Author

podarok commented Sep 18, 2024

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4931/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4931/install.php

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4931/

@podarok
Copy link
Author

podarok commented Sep 18, 2024

Module should be enabled before these hook_update_N executed

">  [error]  Configuration <em class=\"placeholder\">core.entity_view_display.node.lb_event.default</em> depends on the <em class=\"placeholder\">system.menu.utility</em> configuration that will not exist after import. ",
        ">  [error]  Update failed: y_lb_article_update_91001 ",
        ">  [notice] Update started: admin_toolbar_update_8003",
        ">  [notice] Update completed: admin_toolbar_update_8003",
        ">  [notice] Update started: field_group_update_8303",
        ">  [notice] Update completed: field_group_update_8303",
        ">  [notice] Update started: lb_cards_update_9012",
        ">  [error]  Configuration <em class=\"placeholder\">core.entity_view_display.node.lb_event.default</em> depends on the <em class=\"placeholder\">system.menu.utility</em> configuration that will not exist after import. ",
        ">  [error]  Update failed: lb_cards_update_9012 ",
        ">  [notice] Update started: lb_hero_update_10002",
        ">  [error]  Configuration <em class=\"placeholder\">core.entity_view_display.node.lb_event.default</em> depends on the <em class=\"placeholder\">system.menu.utility</em> configuration that will not exist after import. ",
        ">  [error]  Update failed: lb_hero_update_10002 ",
        ">  [notice] Update started: lb_ping_pong_update_9002",
        ">  [error]  Configuration <em class=\"placeholder\">core.entity_view_display.node.lb_event.default</em> depends on the <em class=\"placeholder\">system.menu.utility</em> configuration that will not exist after import. ",
        ">  [error]  Update failed: lb_ping_pong_update_9002 ",
        ">  [notice] Update started: link_attributes_update_9001",
        ">  [notice] Update completed: link_attributes_update_9001",
        ">  [notice] Update started: openy_calc_update_9001",
        ">  [notice] Update completed: openy_calc_update_9001",
        ">  [notice] Update started: openy_editor_update_91002",
        ">  [warning] You have manual updated editor.editor.full_html config from Open Y profile.",
        ">  [notice] Update completed: openy_editor_update_91002",
        ">  [notice] Update started: openy_media_image_update_10001",
        ">  [warning] You have manual updated core.entity_view_display.media.image.embedded_full config from Open Y profile.",
        ">  [warning] You have manual updated core.entity_view_display.media.image.embedded_half config from Open Y profile.",
        ">  [notice] Update completed: openy_media_image_update_10001",
        ">  [notice] Update started: openy_prgf_mbrshp_calc_update_10101",
        ">  [error]  Configuration <em class=\"placeholder\">core.entity_view_display.node.lb_event.default</em> depends on the <em class=\"placeholder\">system.menu.utility</em> configuration that will not exist after import. ",
        ">  [error]  Update failed: openy_prgf_mbrshp_calc_update_10101 ",
        ">  [notice] Update started: ws_event_update_9025",
        ">  [notice] Update completed: ws_event_update_9025",
        ">  [notice] Update started: y_branch_update_9011",
        ">  [notice] Update completed: y_branch_update_9011",
        ">  [notice] Update started: y_camp_update_9015",
        ">  [notice] Update completed: y_camp_update_9015",
        ">  [notice] Update started: y_facility_update_9006",
        ">  [notice] Update completed: y_facility_update_9006",
        ">  [notice] Update started: y_lb_update_9016",
        ">  [notice] Update completed: y_lb_update_9016",
        ">  [notice] Update started: y_lb_main_menu_cta_block_update_10001",
        ">  [notice] Update completed: y_lb_main_menu_cta_block_update_10001",
        ">  [notice] The file public://css/menu_icons.css was not deleted because it does not exist.",
        ">  [notice] The file public://css/menu_icons.css was not deleted because it does not exist.",
        " [error]  Update aborted by: y_lb_article_update_91001, lb_cards_update_9012, lb_hero_update_10002, lb_ping_pong_update_9002, openy_prgf_mbrshp_calc_update_10101 ",
        " [error]  Finished performing updates. ",

@froboy

@froboy
Copy link

froboy commented Sep 18, 2024

@podarok looks like I have to go back and do the config/outdated thing again. I've added this code in all of the new updates:

  $moduleHandler = \Drupal::service('module_handler');
  if (!$moduleHandler->moduleExists('openy_menu_utility')) {
    \Drupal::service('module_installer')->install(['openy_menu_utility']);
  }

but updates are actually failing on a previous update which is pulling in the new config. I'll be back in... a few hours. 😭

@froboy
Copy link

froboy commented Sep 18, 2024

Pushed two fixes:

@froboy
Copy link

froboy commented Sep 18, 2024

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4932/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4932/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4932/

@froboy
Copy link

froboy commented Sep 18, 2024

SCR-20240918-khjt
Utility menu appears as expected on upgrade path. Not added to existing pages.

Waiting for full install to check demo content.

@podarok
Copy link
Author

podarok commented Sep 18, 2024

Good progress @froboy

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4932/

@froboy
Copy link

froboy commented Sep 18, 2024

SCR-20240918-mnyy

@froboy
Copy link

froboy commented Sep 18, 2024

Upgrade path and new install are completing successfully!

@podarok podarok merged commit 4913d05 into main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants