Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Y PEF Schedule app #163

Merged
merged 4 commits into from
Sep 6, 2024
Merged

feat: Add Y PEF Schedule app #163

merged 4 commits into from
Sep 6, 2024

Conversation

podarok
Copy link

@podarok podarok commented Mar 7, 2024

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use main branch. We'll tag for release if the bug is critical ASAP or tag for release next bug fix release until the critical issue arrives.

Steps for review

  • Please provide steps for review here.

General checks

Thank you for your contribution!

@podarok podarok self-assigned this Mar 7, 2024
@ciboxbot
Copy link
Collaborator

ciboxbot commented Mar 7, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4619/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4619/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Mar 7, 2024

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4619/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Mar 7, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4619/

@anpolimus
Copy link
Collaborator

I think, it is better to have this component as separate component like Activity Finder or Virtual Y that could be required by Y that really needs it.

@podarok
Copy link
Author

podarok commented Mar 8, 2024

I think, it is better to have this component as separate component like Activity Finder or Virtual Y that could be required by Y that really needs it.

Activity Finder is not separate
Virtual Y - is

@anpolimus
Copy link
Collaborator

Yes, you are right, AF is not separate now.
We could discuss it on one of our next calls.

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4621/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4621/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4621/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4621/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4623/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4623/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4623/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4623/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4624/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4624/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4624/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4624/

@rollki
Copy link

rollki commented Mar 12, 2024

Steps to reproduce:

  1. Enable the y_pef_schedule module on the extensions page
  2. Go to the branch selection page (/admin/openy/branch-schedules), you can also go to this page from the administrative menu (Content -> Schedules Calendar)
  3. Choose any available branch
  4. You should now be able to view the calendar including:
  • download the current view in PDF format
  • filter by category (by pressing the Legend+ button)
  • change the view from weekly to daily
  • switch between weeks
  • create events from the calendar (by analogy with Google Calendar), including a series of events (when creating a series of events, only one event is displayed, for correct display you need to reload the page - this should also be discussed)
  • view basic information about the event by clicking on it
  • edit the event from the popover, after clicking on the event
  • drag an event within one day (for other days, dragging is disabled and must be discussed)

@podarok
Copy link
Author

podarok commented Mar 12, 2024

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4626/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4626/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4626/

@rollki
Copy link

rollki commented Mar 12, 2024

@podarok
I'm not sure if the latest version of the module got into this new build, I can't check it.

@rollki
Copy link

rollki commented Mar 12, 2024

So everything is fine with the version, there is another problem.

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4626/

@podarok
Copy link
Author

podarok commented Mar 12, 2024

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4627/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4627/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4627/

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4870/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4870/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4870/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4870/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 2, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4876/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4876/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 2, 2024

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4876/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 2, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4876/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 5, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4879/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4879/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 5, 2024

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4879/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 5, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4879/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 6, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4881/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4881/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 6, 2024

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4881/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Aug 6, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4881/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4895/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4895/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4895/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4895/

@AnastasiiaPys
Copy link

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4897/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4897/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4897/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4897/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Sep 6, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4915/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4915/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Sep 6, 2024

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4915/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Sep 6, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4915/

@podarok podarok merged commit b91a7f8 into main Sep 6, 2024
1 check passed
@podarok podarok deleted the y_pef_schedule branch September 6, 2024 10:30
@podarok
Copy link
Author

podarok commented Sep 6, 2024

I merged it @froboy @AnastasiiaPys
But we need to discuss if this module required in any of profile variations or should stay as it is now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants