Render highway/notes as opaques #977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does fix some quirks like notes/kicknote blending weirdly where you see kick note through a cymbal/etc, or the kick note flashing red before it turns orange at the edge of fading |
theli-ua
force-pushed
the
opaque
branch
3 times, most recently
from
e7a0b02 to
1eeefba
Compare
Instead use ztest always in relevant shaders to draw on top
|
Forgot to mention, but this also removes the hack to clear z-depth between rendering various parts. So this also should significantly reduce the overdraw when rendering highways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in a state where I believe everything is working as intended. Everything is rendered as opaques (mostly, other than hit flash/smoke effects obviously). And fade is applied afterwards as a post effect. Fade is applied as part of UICurve shader right now but could be applied separately. its just cheaper to do it right there. Fade/start position is calculated by projecting highway's coordinates onto the screen viewpoint. As far as I can see it looks the same as current code.
Biggest benefit is that no highway-related materials have to carry whole fading around and not care about it at all.
Second is fixing weird issues like kick note peeking through cymbals and whatnot. or the kick note being incorrect color when its in the fade zone because it doesn't have tonemapping applied correctly to it