Use GPU instancing for notes #964
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonicfind
reviewed
Feb 6, 2025
theli-ua
force-pushed
the
batches-2
branch
3 times, most recently
from
ee1cb68 to
9bb436e
Compare
This allows them to be batched now
So that, say, all parts of notes with same material are rendered together and use instancing automagically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting as a draft to get early feedback.
As of posting GPU instancing will only be used for rectangular normal note.
It'll be one instanced draw per (mesh, material) tuple basically. So if only normal rectangular notes are rendered it'll be 3 total for them, like this (frame debugger)