Add support for shift indicators for five fret instruments #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All credit to grishhung for providing the solution to the correct lerp calculation.
…on of shift indicator based on shift range.
wyrdough
force-pushed
the
fivefret-shift-indicator
branch
from
8f53821 to
6c3ba95
Compare
Fix unwanted fade out when deactivating already inactive fret.
wyrdough
force-pushed
the
fivefret-shift-indicator
branch
from
6feee39 to
dd3621d
Compare
wyrdough
force-pushed
the
fivefret-shift-indicator
branch
from
dd3621d to
ce299e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for shift indicators on five fret instruments, using range shift text events found in some of the YARG setlist songs.
During initialization the list of text events attached to the note track is scanned for events with the form
[ld_range_shift d r s]where d is the difficulty, r is the 1 indexed range, and s is the number of frets in the range. Any frets not in the initial range are grayed out.When a range shift event occurs, range shift markers are shown at the four preceding beat lines on the track and the currently inactive frets coming into use flash at each range shift marker.
Shift marker, currently identical to the pro keys range shift marker:
Fading out from the beat line flash:
Once the event has passed, the now active frets are colored and the now inactive frets fade to gray.