Update BASS and use new flag to fix MOGGs with <= 8 channels #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stream has <= 8 channels in BASS, it assumes speaker ordering to align with 5.1/7.1 speaker configurations which broke panning for MOGGs. After some back and forth on the BASS forums, we got an updated binary with a new flag to disable channel reordering.
This updated binary isn't easily downloadable, so I've gone ahead and checked in all the BASS libraries we use (the license permits this for free software), removing the need for the python script.
I currently only have the update for Windows 64 and 32 bit, so I'm opening this as a draft PR while I wait for the other binaries. Testing of this fix is appreciated.
Changes: