Clean up venue track parsing code and parse in some new venue events #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lighting keyframe next/previous (also added handling) - Performer singalongs and spotlights (not handled yet) - Post-processing events (not handled yet) - Bonus effects (not handled yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than converting legacy venues to the new format before parsing, both types of venues are now handled by the same code. Any note-to-text-event conversions happen as part of parsing, rather than as a pre-parsing step.
Some additional venue events are now parsed, though not all are handled just yet:
Camera cuts are still not processed currently, it would be best to create a new info type for them.