Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toasts #256

Merged
merged 3 commits into from
May 6, 2023
Merged

Added toasts #256

merged 3 commits into from
May 6, 2023

Conversation

TheFatBastid
Copy link
Contributor

There are 5 public calls that can be made, ToastWarning(), ToastMessage(), ToastError(), ToastInformation(), and ToastGeneral(). Should be used similarly to debug.log. Added an example in UpdateChecker. Added 2 internal checkers as well (devices at start, devices connected/disconnected). Had to move the loading abort button to the other side. Thanks to Kadu for the art!

There are 5 public calls that can be made, ToastWarning(), ToastMessage(), ToastError(), ToastInformation(), and ToastGeneral(). Should be used similarly to debug.log. Added an example in UpdateChecker. Added 2 internal checkers as well (devices at start, devices connected/disconnected). Had to move the loading abort button to the other side. Thanks to Kadu for the art!
Copy link
Member

@EliteAsian123 EliteAsian123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've been wanted to add toasts, but I'm too lazy. Appreciated as always! Please look at review comments, and then I can merge.

Assets/Script/UI/ToastManager.cs Outdated Show resolved Hide resolved
Assets/Script/UI/ToastManager.cs Outdated Show resolved Hide resolved
Assets/Script/UI/ToastManager.cs Show resolved Hide resolved
@EliteAsian123 EliteAsian123 merged commit c4754e5 into YARC-Official:master May 6, 2023
@TheFatBastid TheFatBastid deleted the patch-11 branch May 13, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants