Fix bonus solo points being awarded when solo completion is MESSY (50-59%) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muskit
changed the title
muskit
changed the title
muskit
changed the title
EliteAsian123
added a commit
that referenced
this pull request
May 4, 2023
* Add UniTask and EasySharpIni * Start new song scanning * Read song cache * Fix StarDisplay gold progress pulse call not resetting the pulse animation (#226) * fixed anim warnings triggering after gold stars achieved * Move ScoreDisplay if MicPlayer isn't present * fix star display pulse call not resetting the pulse animation * remove accidentally left-in log * Sustain animation update (#225) * Sustain Lines thicker and emission fixed * Update sustain animations --------- Co-authored-by: Mia Berth <miaberthrage@gmail.com> * Don't do anything on debounce override if disabled or timer isn't running (#224) * New settings (#220) * Started new settings * Started to add settings back * Added localizations * Tabs * Text input texture * Almost there! * Added Buttons * Fixed some bugs * Fixed merge issue * Updated button texture * Icons and headers * Abstraction * Started track preview in settings * Track camera settings! * Simplified camera positioning * Song folder manager * Fixed render texture issue * Fixed scene merge * Fixed prefab merge * add song update functionality (#185) (#221) Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> * "Fixed" errors * note count hit, solo reset*, slightly easier tap recovery (#222) * Fix StarDisplay gold progress pulse call not resetting the pulse animation (#226) * fixed anim warnings triggering after gold stars achieved * Move ScoreDisplay if MicPlayer isn't present * fix star display pulse call not resetting the pulse animation * remove accidentally left-in log * Sustain animation update (#225) * Sustain Lines thicker and emission fixed * Update sustain animations --------- Co-authored-by: Mia Berth <miaberthrage@gmail.com> * Don't do anything on debounce override if disabled or timer isn't running (#224) * Start new song scanning * Read song cache * Update README.md * Slide reverb volume up and down (#229) * GOT HER DONE (Temporary fix) * Fixed particle group issue * Add notes file and song type to SongEntry * minor overstrum-related fix (#239) * small RB song fixes (#238) * add hopo_threshold support to please jnack * fix DXT3 image byte parsing * DXT3 loop cleanup * hopo threshold fix * actually reference hopo_threshold this time * small RB fixes * fix solo bonus minimum to be at 60% instead of 50% (#234) * Change semitone shift calculation to linear functions (#231) * Fix Discord Unpause Timer (#230) - Using Play.Instance.SongTime to calculate the time left of the song; - Removed unused variables; - Add code for a future implementation * Updated credits * New song select (#245) * New Music Library + Added base design for the new library + Source Icons added (78 Icons for now, will implement more in the future, for now mainly base games) - Still need to add scrollbar to the list - Need to rework the whole Filter/Search bar * Music Library Update + Added default icon for songs that don't have a source - Removed extra folders in the Sources folder (also EA need to fix this to use the right path, I'm just dumb) * Fix song select being active by default * Updated Library + Added search function to the tags (Album, Source Name and Icon, Charter, Genre and Year) + Added new filters for album: charter: genre: and year: - Instrument Difficulty display needs rework with the new visual - Need help adding the search function to the artist name, not sure how since we're using just one component for now (help pls) - Still need to adjust the Subheader (Working on Figma first) * Source Icons UPDATED: + Rock Band + Rock Band 2 + Rock Band 3 + Rock Band 4 + Guitar Hero Aerosmith NEW: + Band Hero DS + Guitar Hero: On Tour Decades + Guitar Hero: On Tour Modern Hits + Guitar Hero TV + Goulart + Hugh + Power Gig + Rock Revolution + Phase Shift * Music Library Update + Source Icons (#236) * New Music Library + Added base design for the new library + Source Icons added (78 Icons for now, will implement more in the future, for now mainly base games) - Still need to add scrollbar to the list - Need to rework the whole Filter/Search bar * Music Library Update + Added default icon for songs that don't have a source - Removed extra folders in the Sources folder (also EA need to fix this to use the right path, I'm just dumb) * Fix song select being active by default * Updated Library + Added search function to the tags (Album, Source Name and Icon, Charter, Genre and Year) + Added new filters for album: charter: genre: and year: - Instrument Difficulty display needs rework with the new visual - Need help adding the search function to the artist name, not sure how since we're using just one component for now (help pls) - Still need to adjust the Subheader (Working on Figma first) * Source Icons UPDATED: + Rock Band + Rock Band 2 + Rock Band 3 + Rock Band 4 + Guitar Hero Aerosmith NEW: + Band Hero DS + Guitar Hero: On Tour Decades + Guitar Hero: On Tour Modern Hits + Guitar Hero TV + Goulart + Hugh + Power Gig + Rock Revolution + Phase Shift --------- Co-authored-by: Nathan <nathanhurst03@gmail.com> * Small changes * Music Library Update + Added new Source Icons + Fixed category header text (1 Song, X Songs) * Difficulty rings + scroll bar * Fixed search --------- Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> * Parallel scanning if folders are on different drives * Migrate everything to use SongEntry, quite non functional right now --------- Co-authored-by: muskit <15199219+muskit@users.noreply.github.com> Co-authored-by: Narrik Synthfox <80410683+NarrikSynthfox@users.noreply.github.com> Co-authored-by: Mia Berth <miaberthrage@gmail.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: Paulo Cardoso <50218490+nevespt@users.noreply.github.com> Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com>
EliteAsian123
added a commit
that referenced
this pull request
May 6, 2023
* Start of new song scanning (#223) * Add UniTask and EasySharpIni * Start new song scanning * Read song cache * New settings (#220) * Started new settings * Started to add settings back * Added localizations * Tabs * Text input texture * Almost there! * Added Buttons * Fixed some bugs * Fixed merge issue * Updated button texture * Icons and headers * Abstraction * Started track preview in settings * Track camera settings! * Simplified camera positioning * Song folder manager * Fixed render texture issue * Fixed scene merge * Fixed prefab merge * add song update functionality (#185) (#221) Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> * "Fixed" errors * note count hit, solo reset*, slightly easier tap recovery (#222) * Fix StarDisplay gold progress pulse call not resetting the pulse animation (#226) * fixed anim warnings triggering after gold stars achieved * Move ScoreDisplay if MicPlayer isn't present * fix star display pulse call not resetting the pulse animation * remove accidentally left-in log * Sustain animation update (#225) * Sustain Lines thicker and emission fixed * Update sustain animations --------- Co-authored-by: Mia Berth <miaberthrage@gmail.com> * Don't do anything on debounce override if disabled or timer isn't running (#224) * Start new song scanning * Read song cache --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: muskit <15199219+muskit@users.noreply.github.com> Co-authored-by: Narrik Synthfox <80410683+NarrikSynthfox@users.noreply.github.com> Co-authored-by: Mia Berth <miaberthrage@gmail.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> * Migrate everything to use new song scanning (#247) * Add UniTask and EasySharpIni * Start new song scanning * Read song cache * Fix StarDisplay gold progress pulse call not resetting the pulse animation (#226) * fixed anim warnings triggering after gold stars achieved * Move ScoreDisplay if MicPlayer isn't present * fix star display pulse call not resetting the pulse animation * remove accidentally left-in log * Sustain animation update (#225) * Sustain Lines thicker and emission fixed * Update sustain animations --------- Co-authored-by: Mia Berth <miaberthrage@gmail.com> * Don't do anything on debounce override if disabled or timer isn't running (#224) * New settings (#220) * Started new settings * Started to add settings back * Added localizations * Tabs * Text input texture * Almost there! * Added Buttons * Fixed some bugs * Fixed merge issue * Updated button texture * Icons and headers * Abstraction * Started track preview in settings * Track camera settings! * Simplified camera positioning * Song folder manager * Fixed render texture issue * Fixed scene merge * Fixed prefab merge * add song update functionality (#185) (#221) Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> * "Fixed" errors * note count hit, solo reset*, slightly easier tap recovery (#222) * Fix StarDisplay gold progress pulse call not resetting the pulse animation (#226) * fixed anim warnings triggering after gold stars achieved * Move ScoreDisplay if MicPlayer isn't present * fix star display pulse call not resetting the pulse animation * remove accidentally left-in log * Sustain animation update (#225) * Sustain Lines thicker and emission fixed * Update sustain animations --------- Co-authored-by: Mia Berth <miaberthrage@gmail.com> * Don't do anything on debounce override if disabled or timer isn't running (#224) * Start new song scanning * Read song cache * Update README.md * Slide reverb volume up and down (#229) * GOT HER DONE (Temporary fix) * Fixed particle group issue * Add notes file and song type to SongEntry * minor overstrum-related fix (#239) * small RB song fixes (#238) * add hopo_threshold support to please jnack * fix DXT3 image byte parsing * DXT3 loop cleanup * hopo threshold fix * actually reference hopo_threshold this time * small RB fixes * fix solo bonus minimum to be at 60% instead of 50% (#234) * Change semitone shift calculation to linear functions (#231) * Fix Discord Unpause Timer (#230) - Using Play.Instance.SongTime to calculate the time left of the song; - Removed unused variables; - Add code for a future implementation * Updated credits * New song select (#245) * New Music Library + Added base design for the new library + Source Icons added (78 Icons for now, will implement more in the future, for now mainly base games) - Still need to add scrollbar to the list - Need to rework the whole Filter/Search bar * Music Library Update + Added default icon for songs that don't have a source - Removed extra folders in the Sources folder (also EA need to fix this to use the right path, I'm just dumb) * Fix song select being active by default * Updated Library + Added search function to the tags (Album, Source Name and Icon, Charter, Genre and Year) + Added new filters for album: charter: genre: and year: - Instrument Difficulty display needs rework with the new visual - Need help adding the search function to the artist name, not sure how since we're using just one component for now (help pls) - Still need to adjust the Subheader (Working on Figma first) * Source Icons UPDATED: + Rock Band + Rock Band 2 + Rock Band 3 + Rock Band 4 + Guitar Hero Aerosmith NEW: + Band Hero DS + Guitar Hero: On Tour Decades + Guitar Hero: On Tour Modern Hits + Guitar Hero TV + Goulart + Hugh + Power Gig + Rock Revolution + Phase Shift * Music Library Update + Source Icons (#236) * New Music Library + Added base design for the new library + Source Icons added (78 Icons for now, will implement more in the future, for now mainly base games) - Still need to add scrollbar to the list - Need to rework the whole Filter/Search bar * Music Library Update + Added default icon for songs that don't have a source - Removed extra folders in the Sources folder (also EA need to fix this to use the right path, I'm just dumb) * Fix song select being active by default * Updated Library + Added search function to the tags (Album, Source Name and Icon, Charter, Genre and Year) + Added new filters for album: charter: genre: and year: - Instrument Difficulty display needs rework with the new visual - Need help adding the search function to the artist name, not sure how since we're using just one component for now (help pls) - Still need to adjust the Subheader (Working on Figma first) * Source Icons UPDATED: + Rock Band + Rock Band 2 + Rock Band 3 + Rock Band 4 + Guitar Hero Aerosmith NEW: + Band Hero DS + Guitar Hero: On Tour Decades + Guitar Hero: On Tour Modern Hits + Guitar Hero TV + Goulart + Hugh + Power Gig + Rock Revolution + Phase Shift --------- Co-authored-by: Nathan <nathanhurst03@gmail.com> * Small changes * Music Library Update + Added new Source Icons + Fixed category header text (1 Song, X Songs) * Difficulty rings + scroll bar * Fixed search --------- Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> * Parallel scanning if folders are on different drives * Migrate everything to use SongEntry, quite non functional right now --------- Co-authored-by: muskit <15199219+muskit@users.noreply.github.com> Co-authored-by: Narrik Synthfox <80410683+NarrikSynthfox@users.noreply.github.com> Co-authored-by: Mia Berth <miaberthrage@gmail.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: Paulo Cardoso <50218490+nevespt@users.noreply.github.com> Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com> * Remove duplicate files and unused imports * Renamed "RawCon" to "ExtractedCon" * Added LoadingManager * Added back score loading * Added extracted CON read/write for song cache (#248) * Added extracted CON read/write for song cache * Difficulty loading from ini * Did an oopsie and realised difficulties would not work * Fixed bug loading mid files * Added back refresh per folder * [New Caching] Fix excon caching and music library bugs (#253) * Added extracted CON read/write for song cache * Difficulty loading from ini * Did an oopsie and realised difficulties would not work * Fixed bug loading mid files * Added BinaryWriter wrapper to handle null strings * Always fast scan on startup * Fix missing difficulties breaking music library * Fix some issues with EXCON caching * Fix incorrect notes file assignment * Added "ErroredCaches" to scanning * Fixed null song folder issue * .chart preparsing (#255) * Fixed warning * Fixed duplicate folder issue * [New Caching] .mid Preparsing, badsong logging and difficulty ring fix (#263) * .chart preparsing * Basic mid preparsing (only instruments) * Lots of preparsing fixes and fixed hopo frequencies * Change where badsongs are written to * Fix difficulty rings showing when no track is present but difficulty is defined * Fix duplicate chart preparsing causing compile error * Settings menu now auto updates cache --------- Co-authored-by: RileyTheFox <jacobchambers@hotmail.co.uk> Co-authored-by: rjkiv <76180273+rjkiv@users.noreply.github.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: muskit <15199219+muskit@users.noreply.github.com> Co-authored-by: Narrik Synthfox <80410683+NarrikSynthfox@users.noreply.github.com> Co-authored-by: Mia Berth <miaberthrage@gmail.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Paulo Cardoso <50218490+nevespt@users.noreply.github.com> Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted solo bonus scoring minimum to be at 60% instead of 50%.
Addresses #227