Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor five-fret engine tweaks #209

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Minor five-fret engine tweaks #209

merged 1 commit into from
Apr 29, 2023

Conversation

raphaelgoulart
Copy link
Contributor

  • ALLOW_DESC_GHOSTS
    • Already implemented, just made into a toggle.
  • ALLOW_GHOST_IF_NO_NOTES
    • If the next note is outside of the timing window, do not check for ghost inputs;
    • For some reason, in some rare scenarios it seems to allow ghosting when it shouldn't;
    • Increasing the ALLOW_GHOST_IF_NO_NOTES_THRESHOLD variable might alleviate that;
    • However if set too large, it might nullify the effect of the toggle.
  • EASY_TAP_RECOVERY
    • If tapping to recover combo during tap note section, skip to first valid note within the timing window. This will make it easier to recover;
    • Only applies if combo is 0, and all following notes are tap notes, so it won't negatively impact FC runs.

@EliteAsian123 EliteAsian123 merged commit 53dcdce into YARC-Official:master Apr 29, 2023
@raphaelgoulart raphaelgoulart deleted the engine-changes branch April 29, 2023 16:30
april83c pushed a commit to april83c/YARG that referenced this pull request Dec 2, 2024
* Add HasValidInstrument property to YargProfile

* Applied PR review changes
Introduced EnsureValidInstrument() to YARG.Core
Applied style change to several one-liner if statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants