-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Audio becomes desynced over the course of a song #17
Comments
Huh. That is odd, and should not happen unless of a huge lag spike. Can you provide an example of a song where this happens? (just the name and source is fine). Thanks for the issue report, and apologies for the inconvinience. |
I was playing Painkiller by Judas Priest and Green Grass and High Tides by The Outlaws(Wavegroup), both of them come from that spreadsheet of songs from Clone Hero: https://docs.google.com/spreadsheets/u/0/d/13B823ukxdVMocowo1s5XnT3tzciOfruhUVePENKc01o/htmlview#gid=0 |
I also have to play on low quality mode, otherwise the game is very laggy. |
Thanks for the info, I'll investigate it ASAP. |
Howdy. Through some investigation, my assumption is that when the game lags, the audio doesn't, which causes desync. To prevent this, I added an option in the settings menu that bases the current time on the audio instead of Unity's delta-time (which is what was being used). Now, there are some issues attached with basing the time off of the audio instead of the game time, but I think that it may solve the problem you are having. Below, I attached a zip-file containing the current dev-build. If you don't mind, can you test to see if this fixes the problem for you? Be sure to go into the settings and turn “Use Audio Time” on. Please be advised that the settings do not save between sessions yet. If this fixes the issue, please close this issue. If not, please let me know. Thanks! Edit: GitHub could not host the file due to size. Here is a Google drive link: |
This seems to have fixed the issue, although now songs don't end. |
Okay, thanks for testing! Yes, I forgot to account for the song ending with the new setting, so that will be fixed with the next release. |
I've fixed the song ending issue. If you'd like to continue playing, here is a dev-build hot-fix. Thanks again! |
…ad in new/missing phrase types (YARC-Official#17) * Merge star power and drum roll events into general special phrases * Rename some phrase definitions * Parse in versus phrases and trill/tremolo lanes on all instruments Trill/tremolo are still restricted to drums on .chart, they're not officially defined for guitar yet
I was playing some longer songs, and it seems like the audio slowly desyncs and gets later, which makes it pretty difficult to hit any notes.
The text was updated successfully, but these errors were encountered: