Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Audio becomes desynced over the course of a song #17

Closed
LegoMaster09 opened this issue Mar 12, 2023 · 8 comments
Closed

(Bug) Audio becomes desynced over the course of a song #17

LegoMaster09 opened this issue Mar 12, 2023 · 8 comments
Labels
Bug Something isn't working

Comments

@LegoMaster09
Copy link

I was playing some longer songs, and it seems like the audio slowly desyncs and gets later, which makes it pretty difficult to hit any notes.

@EliteAsian123
Copy link
Member

Huh. That is odd, and should not happen unless of a huge lag spike.

Can you provide an example of a song where this happens? (just the name and source is fine).
Can you also tell me if you were lag spiking or not?

Thanks for the issue report, and apologies for the inconvinience.

@EliteAsian123 EliteAsian123 added the Bug Something isn't working label Mar 12, 2023
@EliteAsian123 EliteAsian123 changed the title Audio becomes desynced over the course of a song (Bug) Audio becomes desynced over the course of a song Mar 12, 2023
@LegoMaster09
Copy link
Author

I was playing Painkiller by Judas Priest and Green Grass and High Tides by The Outlaws(Wavegroup), both of them come from that spreadsheet of songs from Clone Hero: https://docs.google.com/spreadsheets/u/0/d/13B823ukxdVMocowo1s5XnT3tzciOfruhUVePENKc01o/htmlview#gid=0

@LegoMaster09
Copy link
Author

I also have to play on low quality mode, otherwise the game is very laggy.

@LegoMaster09 LegoMaster09 reopened this Mar 12, 2023
@EliteAsian123
Copy link
Member

Thanks for the info, I'll investigate it ASAP.

@EliteAsian123
Copy link
Member

EliteAsian123 commented Mar 12, 2023

Howdy. Through some investigation, my assumption is that when the game lags, the audio doesn't, which causes desync. To prevent this, I added an option in the settings menu that bases the current time on the audio instead of Unity's delta-time (which is what was being used).

Now, there are some issues attached with basing the time off of the audio instead of the game time, but I think that it may solve the problem you are having.

Below, I attached a zip-file containing the current dev-build. If you don't mind, can you test to see if this fixes the problem for you? Be sure to go into the settings and turn “Use Audio Time” on. Please be advised that the settings do not save between sessions yet.

If this fixes the issue, please close this issue. If not, please let me know. Thanks!

Edit: GitHub could not host the file due to size. Here is a Google drive link: https://drive.google.com/file/d/1JSFvNPGa1-IebQiP7lS6HEPgVb2oazQr/view?usp=share_link (dead).

@LegoMaster09
Copy link
Author

This seems to have fixed the issue, although now songs don't end.

@EliteAsian123
Copy link
Member

Okay, thanks for testing! Yes, I forgot to account for the song ending with the new setting, so that will be fixed with the next release.

@EliteAsian123
Copy link
Member

EliteAsian123 commented Mar 12, 2023

I've fixed the song ending issue. If you'd like to continue playing, here is a dev-build hot-fix. Thanks again!
https://drive.google.com/file/d/1deLy0nuYRkjHyFlwFo1MOrY7b7ZeUhiT/view (dead)

Purplo-cf pushed a commit to Purplo-cf/YARG that referenced this issue May 14, 2024
…ad in new/missing phrase types (YARC-Official#17)

* Merge star power and drum roll events into general special phrases

* Rename some phrase definitions

* Parse in versus phrases and trill/tremolo lanes on all instruments
Trill/tremolo are still restricted to drums on .chart, they're not officially defined for guitar yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants